Rifleman / Observer / Commander:
Pretty good overall. All 4 rifles for both factions feel like they have their own distinct niches. The G3 is a good mid-range heavy hitter, the M16A4/A2 are nice all rounders, and the G36, M4, and both AKs, while there is some overlap, still feel relatively distinct.
The only thing that bothers me is the fact that observers and commanders just get standard rifleman kits with nothing unique. I feel like these classes should get a unique weapon or two to make them a little more interesting. Perhaps an ACR for security and maybe an AS VAL for insurgents?
Breacher:
Not so great if I'm honest, mainly because it feels like every primary the breacher has access to gets overshadowed by the shotguns. It's not that the other weapons are bad, it's just that they don't really compare. Why would I take an MP7 that'll run me at least 7 supply to get it configured properly, when I can have a shotgun with flechette rounds for less than half that cost? Not to mention the carbines are also available to the advisor, so you may as well just pick advisor and leave the breacher kit for your teammate who might want to use a shotgun.
The breacher not only needs its current SMG choices to be a bit better, but also have a few more to pick from. Perhaps a UMP45 for security and a PP-Bizon for insurgents?
Gunner:
One gun per faction. Boring. Not to mention the current meta favors using the LMGs in a somewhat unorthodox fashion, essentially running them like high capacity assault rifles rather than MGs.
I'd like each faction to have weapons that act as counterparts to one another. Maybe security could get an M240B or M60 to act as their counterpart to the insurgents' PKM, and insurgents could get an MG42 (yes, they've actually been seen using these) to act as their counterpart to the security's M249.
Demoliton:
Not much to say. Standard rifleman kit with some more explosive options. Bit annoying how you don't start with full ammo for the underslung launcher / reloadable rocket launcher and have to fill up from a supply cache.
Marksman:
About what I expected. One bolt-action and one DMR. My only gripe is that bolt action rifles can't reliably one shot targets, so they seem redundant when compared to DMRs. Much as I'd like to see more DMRs and BA rifles to pick from, they'd likely just end up being alternative skins rather than different weapons.
Advisor:
I think the insurgent advisor gets a bit of a raw deal here. While the security advisor gets the L85A2 and Mk17, the insurgent advisor only really gets the FAL (I don't count the SVD since it's also on marksman). Insurgent advisor needs some more love. Maybe something like an AN94 (Though I understand if this wouldn't be realistic since, as I understand it, the AN94 is pretty rare).
Additionally, I don't really get what the Mk17 is supposed to be good for. It just seems like a crappy version of the G3, currently.